Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the api package to use builder patterns for constructing API, Message, Service, Method, PathBinding, PathInfo, PathSegment, PathVariable, Resource, ResourceReference, OperationInfo, RoutingInfo, RoutingInfoVariant, and SampleInfo types. It also encapsulates struct fields and provides getter methods for access. The review comment correctly identifies a missing variadic expansion operator in the WithSignatures call within methods.go.
coryan
force-pushed
the
feat/readonly-api-v2
branch
from
October 30, 2026 00:07
bce3596 to
b34a269
Compare
coryan
force-pushed
the
feat/readonly-api-v2
branch
5 times, most recently
from
November 5, 2026 19:55
bd46a4a to
84bb780
Compare
coryan
force-pushed
the
feat/readonly-api-v2
branch
3 times, most recently
from
November 12, 2026 21:57
87ca068 to
f397abe
Compare
coryan
force-pushed
the
feat/readonly-api-v2
branch
from
November 20, 2026 12:13
f397abe to
c9b9933
Compare
Add a generic (*API).Filter method to construct a filtered copy of an API surface, keeping Rust/prost-specific reachability rules in internal/librarian/rust/generate_prost_hybrid.go. Part of googleapis#7837
Make API fields private with getters and APIBuilder. Part of googleapis#7837 Closes googleapis#7857
coryan
force-pushed
the
feat/readonly-api-v2
branch
from
November 20, 2026 14:49
c9b9933 to
d1504d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT REVIEW
This is the end of a long list of PRs towards #7837. The idea is to make the
api.Ttypes read-only, so once initialized by the parsers (or tests) they can only get annotations in the codec. It is harder to use the types incorrectly, probably easier to fix things, and constraint the mistakes that LLMs can make.